London 9 - Lovelace - Oleksii Chepurnyi - JavaScript-Core1-Coursework-Week1 by OleksChep · Pull Request #435 · CodeYourFuture/JavaScript-Core-1-Coursework-Week1

OleksChep · 2022-11-24T00:04:43Z

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

Your Name: Oleksii Chepurnyi
Your City: London
Your Slack Name: Oleks

Homework Details

Module: JavaScript-Core1-Coursework-Week1
Week: 1

Notes

What did you find easy?
Operators
What did you find hard?
Functions / TESTS !
What do you still not understand?
Tests / How it works ?
Any other notes?
How works Tests ?

View rendered exercises/K-functions-parameters/README.md

jonnywyatt

You smashed this! Well done.

jonnywyatt · 2022-11-24T18:19:10Z

+var introduce2 = "characters long.";
+var message =
+  introduce1 + name1 + " " + introduce3 + nameLength + " " + introduce2;
+console.log(message.trim());


jonnywyatt · 2022-11-24T18:20:26Z

+var ment = "Number of mentors: ";
+console.log(ment + numberOfMentors);
+var total = "Total number of students and mentors: ";
+var sum = numberOfMentors + numberOfStudents;


jonnywyatt · 2022-11-24T18:22:45Z

 // Complete the function so that it takes input parameters
-function multiply() {
-  // Calculate the result of the function and return it
+function multiply(a, b) {


jonnywyatt · 2022-11-24T18:24:56Z

-function convertToUSD() {}
+function convertToUSD(price) {
+  let priceDolar = pricePound*1.4;
+  return "$" + priceDolar.toFixed(2);


Excellent - toFixed is the right thing to use here

jonnywyatt · 2022-11-24T18:26:09Z

+return a + b + c;
+}
+function introduceMe(name, age) {
+  return "Hello, my name is " + '${name}' + "and I am " + '${age}' + " years old";


Will '${name}' just print out the name?

i don t know

jonnywyatt · 2022-11-24T18:27:15Z

-
-  return "The total is total";
+  total = a + b;
+  return "The total is ${total}";


Close - you're using template string syntax here, but to make it work you need to use backticks ` instead of " to surround the string.

If you don't use backticks then ${total} won't be replaced by the value of total. For instance:

let a = 34; console.log("a is ${a}"); // will print: a is ${a} console.log(`a is ${a}`); // will print: a is 34

jonnywyatt · 2022-11-24T18:28:42Z

+//The implementation selects the initial seed to the random number generation 
+//algorithm; it cannot be chosen or reset by the user.
+//Return value A floating-point, pseudo-random number between 0 (inclusive) and 1 (exclusive).
+//  0 < Number <  10 ;


The generated number will be between 0 and 1
so, 0 < Number < 1

jonnywyatt · 2022-11-24T18:31:18Z

-function addTaxAndFormatCurrency() {}
+function addTaxAndFormatCurrency(price) {
+  let newPrice = calculateSalesTax(price);
+  return "£" + newPrice.toFixed(2);


Excellent. Maybe one small improvement? Every time you use the calculateSalesTax function, you'll have to call toFixed on the result. How can you save from having to do that each time you call it?

do not understand question , sorry

maxf

Well done, you've got it mostly right.
Did you run the tests, as explained in the README file?
Not all of them pass, so I just want to check if you managed to run them yourself?

Also, when you answer the questions (what did you find easy, etc), you're allowed to use more than one word!

And thanks a lot @jonnywyatt for your review :)

maxf · 2022-11-24T19:52:17Z

@@ -1,3 +1,7 @@
 // Start by creating a variable `greeting`
-
+var greeting = "Hello world";


You should avoid var. As mentioned last week, prefer using let or const. var is old, has tricky semantics, and is no longer needed.

maxf · 2022-11-24T19:54:15Z


+var name1 = "Oleks";
+var nameLength = name1.length;
+var introduce1 = "      My name is ";


Why all the whitespace at the start?

maxf · 2022-11-24T19:55:55Z

+var total = "Total number of students and mentors: ";
+var sum = numberOfMentors + numberOfStudents;
+console.log(total + sum);
+var percentageStudents = 100*numberOfStudents/sum


Don' forget the ; at the end of the line. Even if it won't change the behaviour of your code, it's better to stay consistent.

maxf · 2022-11-24T19:58:45Z

 // Declare your function first
-
+function divide ( a, b) {
+    return a / b;


The indentation of this line is 4 characters, while you use 1 above in your code. Again, for the sake of consistency and readability, always use the same amount.

maxf · 2022-11-24T20:02:16Z

 */

-function convertToUSD() {}
+function convertToUSD(price) {


I think you meant pricePound here.
Otherwise it's good idea to use the currency in the name of the variable or parameter. Same with units: distanceInMeters, waveLengthCm, etc. It can be useful to avoid any confusion when sharing your code.

maxf · 2022-11-24T20:04:07Z


 function getStringLength(word) {
-  return "word".length();
+  return word.length();


It's word.length. It's unclear why JavaScript does it this way, so we just accept it :)

OleksChep · 2022-11-25T12:31:56Z

Thanks for the review

OleksChep · 2022-11-28T16:46:28Z

Well done, you've got it mostly right. Did you run the tests, as explained in the README file? Not all of them pass, so I just want to check if you managed to run them yourself?
I did not run the tests

Also, when you answer the questions (what did you find easy, etc), you're allowed to use more than one word!

And thanks a lot @jonnywyatt for your review :)

OleksChep · 2022-11-28T16:47:26Z

How
pass tests ?

maxf · 2022-11-28T16:56:30Z

To run the tests, see the instructions:
https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1#running-the-codetests

OleksChep added 17 commits November 21, 2022 23:11

done A, B exercises

6e80e6e

Update exercise

4bf5b49

D-strings

2fc87fb

E

2a4378d

e-exercise

596420b

D ex1 ex2

25b1baa

G-numbers total

fad3f7e

I- floats ex

7c38916

add comments

b9d60af

J functions

d9011c4

K

06113c5

final exercises

9d801b4

first mandatory

4e0dc67

2 logic - 3 errors

c743152

3-functions

2d32725

mandatory update 4-tax.js

21df378

extra currency conversion dolar

683f499

maxf self-requested a review November 24, 2022 13:54

jonnywyatt reviewed Nov 24, 2022

View reviewed changes

maxf reviewed Nov 24, 2022

View reviewed changes

jonnywyatt added the reviewed label Nov 27, 2022

OleksChep added 5 commits November 30, 2022 23:21

testing mandatory ex 1 and 2 and fixing errors

7a31cec

Update 1-currency-conversion.js

51f831b

Update 1-currency-conversion.js

d5006a9

Update 2-piping.js

1af7570

Update 3-magic-8-ball.js

4e7e47d

Update 3-magic-8-ball.js

897c770

		@@ -1,3 +1,7 @@
		// Start by creating a variable `greeting`

		var greeting = "Hello world";

Uh oh!

Uh oh!

Conversation

OleksChep commented Nov 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Your Details

Homework Details

Notes

Uh oh!

jonnywyatt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maxf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OleksChep commented Nov 25, 2022

Uh oh!

OleksChep commented Nov 28, 2022

Uh oh!

OleksChep commented Nov 28, 2022

Uh oh!

maxf commented Nov 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OleksChep commented Nov 24, 2022 •

edited

Loading

maxf left a comment •

edited

Loading